Investigation Requirements

Oct 13, 2025 by pinkandtrash.com 117 views

Fix Missing Data: Three-Point Rate (ID: S03)

Feature Information

The Three-Point Rate feature, denoted by ID S03, falls under the shooting category and has a complexity level of 1️⃣. This feature is crucial in evaluating a team's shooting efficiency, particularly from beyond the 3-point arc.

Problem Description

A thorough examination of the full_feature_set.parquet file reveals that the Three-Point Rate feature is missing values for more than 99% of rows. This significant issue necessitates a proper calculation and inclusion of this essential shooting style metric for all teams and seasons.

Investigation Requirements

To address the missing data issue, a comprehensive investigation is required. The following steps should be taken:

Review the complete implementation at src/features/shooting/S03_three_point_rate.py to identify any potential errors or inconsistencies.
Examine the raw data sources in data/raw to verify the existence of necessary 3-point attempt data.
Check if there are any issues in the data processing pipeline that converts raw data to processed data.
Investigate potential data quality issues in the raw/processed data specifically for 3-point field goal attempts.
Verify if the feature calculation methodology is correct and handles potential division by zero.
Consider if additional data sources could be used for imputation, such as play_by_play data that might contain shot type information.
Check for potential calculation errors, edge cases, or schema inconsistencies.
Review unit tests to ensure they properly validate the feature implementation.

Implementation Fixes

To resolve the missing data issue, the following implementation fixes should be made:

Fix the implementation to properly calculate Three-Point Rate for all teams and seasons.
Enhance the feature calculation to handle missing data appropriately.
Consider imputation strategies for teams and seasons with incomplete data.
Update unit tests at tests/features/shooting/test_S03_three_point_rate.py.
Verify documentation at docs/features/shooting/S03_three_point_rate.md is accurate.
Ensure the feature implementation works with the pipeline framework.

Technical Details

Three-Point Rate measures the percentage of a team's field goal attempts that come from beyond the 3-point arc. The formula is:

3PA / FGA

Where:

3PA = Three-point field goal attempts
FGA = Total field goal attempts

Investigate if any of these input variables are missing or incorrectly processed from raw data to processed data. There might be inconsistencies in how 3-point attempts are recorded across different seasons, especially for older data.

Acceptance Criteria

To ensure the feature implementation meets the required standards, the following acceptance criteria should be met:

Feature Implementation

The feature is calculated correctly for at least 95% of teams and seasons.
The implementation includes appropriate handling for edge cases and missing data.
Unit tests pass and achieve at least 90% code coverage.
Documentation is complete and follows the template.
FEATURES.md status is updated to reflect implementation status.
Code follows project coding standards.
Performance is acceptable for dataset size.

PR Preparation (Required Before Submission)

Before submitting the PR, ensure the following steps are completed:

Step 1: Comprehensive Testing
- All tests pass (run python -m pytest).
Step 2: Code Linting
- Code passes linting with no warnings or errors (run ruff check .).
- No linting exceptions or # noqa comments added.
Step 3: End-to-End Validation
- Pipeline runs successfully with existing data (run python run_pipeline.py).
- Pipeline runs successfully with clean data (run python run_pipeline.py --clean-all).
- Final verification passes (run pytest, ruff check ., and python run_pipeline.py).

Related Features

The following features are related to the Three-Point Rate feature:

S01 Effective Field Goal Percentage: Uses three-point shots in its calculation.
S02 True Shooting Percentage: Another shooting efficiency metric.
S06 Shooting Distribution: Will include three-point shooting as a component.

Resources

The following resources should be considered when addressing the missing data issue:

The team_box data should contain fields for field goal attempts (fga) and three-point attempts (fg3a).
Consider analyzing the schema of raw data files to ensure consistent naming conventions across seasons.
Historical three-point line changes (distance changes in NCAA) might affect this metric across years.
Fix Missing Data: Three-Point Rate (ID: S03) - Q&A

Frequently Asked Questions

Q: What is the Three-Point Rate feature, and why is it important?

A: The Three-Point Rate feature measures the percentage of a team's field goal attempts that come from beyond the 3-point arc. It is an essential shooting style metric that provides valuable insights into a team's shooting efficiency.

Q: Why is the Three-Point Rate feature missing values for more than 99% of rows?

A: The missing values are likely due to inconsistencies in how 3-point attempts are recorded across different seasons, especially for older data. Additionally, there might be issues in the data processing pipeline that converts raw data to processed data.

Q: What are the investigation requirements to address the missing data issue?

A: The following steps should be taken:

Review the complete implementation at src/features/shooting/S03_three_point_rate.py to identify any potential errors or inconsistencies.
Examine the raw data sources in data/raw to verify the existence of necessary 3-point attempt data.
Check if there are any issues in the data processing pipeline that converts raw data to processed data.
Investigate potential data quality issues in the raw/processed data specifically for 3-point field goal attempts.
Verify if the feature calculation methodology is correct and handles potential division by zero.
Consider if additional data sources could be used for imputation, such as play_by_play data that might contain shot type information.
Check for potential calculation errors, edge cases, or schema inconsistencies.
Review unit tests to ensure they properly validate the feature implementation.

Q: What are the implementation fixes to resolve the missing data issue?

A: The following implementation fixes should be made:

Fix the implementation to properly calculate Three-Point Rate for all teams and seasons.
Enhance the feature calculation to handle missing data appropriately.
Consider imputation strategies for teams and seasons with incomplete data.
Update unit tests at tests/features/shooting/test_S03_three_point_rate.py.
Verify documentation at docs/features/shooting/S03_three_point_rate.md is accurate.
Ensure the feature implementation works with the pipeline framework.

Q: What are the technical details of the Three-Point Rate feature?

A: The formula for Three-Point Rate is:

3PA / FGA

Where:

3PA = Three-point field goal attempts
FGA = Total field goal attempts

Investigate if any of these input variables are missing or incorrectly processed from raw data to processed data.

Q: What are the acceptance criteria for the feature implementation?

A: The following acceptance criteria should be met:

The feature is calculated correctly for at least 95% of teams and seasons.
The implementation includes appropriate handling for edge cases and missing data.
Unit tests pass and achieve at least 90% code coverage.
Documentation is complete and follows the template.
FEATURES.md status is updated to reflect implementation status.
Code follows project coding standards.
Performance is acceptable for dataset size.

Q: What are the PR preparation steps required before submission?

A: The following steps should be completed:

Step 1: Comprehensive Testing
- All tests pass (run python -m pytest).
Step 2: Code Linting
- Code passes linting with no warnings or errors (run ruff check .).
- No linting exceptions or # noqa comments added.
Step 3: End-to-End Validation
- Pipeline runs successfully with existing data (run python run_pipeline.py).
- Pipeline runs successfully with clean data (run python run_pipeline.py --clean-all).
- Final verification passes (run pytest, ruff check ., and python run_pipeline.py).

Q: What are the related features to the Three-Point Rate feature?

A: The following features are related to the Three-Point Rate feature:

S01 Effective Field Goal Percentage: Uses three-point shots in its calculation.
S02 True Shooting Percentage: Another shooting efficiency metric.
S06 Shooting Distribution: Will include three-point shooting as a component.

Q: What resources should be considered when addressing the missing data issue?

A: The following resources should be considered:

The team_box data should contain fields for field goal attempts (fga) and three-point attempts (fg3a).
Consider analyzing the schema of raw data files to ensure consistent naming conventions across seasons.
Historical three-point line changes (distance changes in NCAA) might affect this metric across years.